Skip to content

Restoring autoConvert behavior in Clipboard APIs #11837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shyam-Gupta wants to merge 4 commits into
base: main
Choose a base branch
from
+26 −3
Open

Restoring autoConvert behavior in Clipboard APIs #11837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f04d7d0
Restoring autoConvert to .NET 8.0 in Clipboard APIs
Shyam-Gupta Aug 12, 2026
6f4cb02
Added unit test
Shyam-Gupta Aug 12, 2026
643d4ad
Also setting autoConvert to false in one of the TryGetData overload.
Shyam-Gupta Aug 12, 2026
d2f87e6
Formatting
Shyam-Gupta Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/clipboard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,16 @@ public static bool ContainsText(TextDataFormat format) => !DataFormats.IsValidTe
private static T? GetTypedDataIfAvailable<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] T>(string format)
{
IDataObject? data = GetDataObject();
bool autoConvert = IsDataFormatAutoConvert(format);

if (data is ITypedDataObject typed)
{
return typed.TryGetData(format, autoConvert: true, out T? value) ? value : default;
return typed.TryGetData(format, autoConvert, out T? value) ? value : default;
}

if (data is IDataObject dataObject)
{
return dataObject.GetData(format, autoConvert: true) is T value ? value : default;
return dataObject.GetData(format, autoConvert) is T value ? value : default;
}

return default;
Expand Down Expand Up @@ -485,7 +487,7 @@ public static bool TryGetData<T>(
return false;
}

return dataObject.TryGetData(format, out data);
return dataObject.TryGetData(format, autoConvert: false, out data);
}

/// <inheritdoc cref="DataObject.SetDataAsJson{T}(string, T)"/>
Expand Down
21 changes: 21 additions & 0 deletions ...rosoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/System/Windows/ClipboardTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,27 @@ public void SetDataObject_WithMultipleData(bool copy)
result2.Should().Be(testData2);
}

[WpfTheory]
[InlineData(TextDataFormat.Text, TextDataFormat.UnicodeText)]
[InlineData(TextDataFormat.UnicodeText, TextDataFormat.Text)]
public void GetText_AutoConvertibleFormat_DoesNotAutoConvert(
TextDataFormat sourceFormat,
TextDataFormat requestedFormat)
{
const string text = "Hello, World!";
string sourceDataFormat = DataFormats.ConvertToDataFormats(sourceFormat);
string requestedDataFormat = DataFormats.ConvertToDataFormats(requestedFormat);
DataObject dataObject = new();
dataObject.SetData(sourceDataFormat, text, autoConvert: true);

dataObject.GetData(requestedDataFormat, autoConvert: true).Should().Be(text);
dataObject.GetData(requestedDataFormat, autoConvert: false).Should().BeNull();

Clipboard.SetDataObject(dataObject);

Clipboard.GetText(requestedFormat).Should().BeEmpty();
}

[WpfFact]
public void SetData_Text_Format_AllUpper()
{
Expand Down