Skip to content

Fixed assignment of values to file contents. - #816

Merged
GROwen merged 2 commits into
developfrom
feature/set-file-value-to-env-var-value
Aug 25, 2026
Merged

Fixed assignment of values to file contents.#816
GROwen merged 2 commits into
developfrom
feature/set-file-value-to-env-var-value

Conversation

@GROwen

@GROwen GROwen commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Motivation

When the env vars TIDE_OAUTH_PUBLIC_KEY and TIDE_OAUTH_PRIVATE_KEY were set and the command drush tide-oauth:keygen was executed, the resulting contents of the oauth files were the names of the env vars not the values of the env vars.

Changed

  1. Updated the lookup of env vars in the assignment to write time instead of relying on the constructor.

Screenshots

@datadog-dpc-sdp

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 1 Pipeline job failed

build | tide_build — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

Exceeds line length limit: Line exceeds 80 characters; contains 81 characters in code.

📋 Copy fix prompt
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Before you start, set up the Datadog software-delivery tooling so you can
query the CI data yourself:

1. Check whether you already have the Datadog software-delivery MCP tools
   (e.g. a `search_datadog_ci_pipeline_events` tool) and the `unblock-pr` skill.
2. If either is missing, STOP and ask me for permission before installing
   anything. Do not install or run anything until I have said yes.
3. Only with my explicit approval, set up the Datadog software-delivery MCP
   server and skills by following:
     https://docs.datadoghq.com/getting_started/software_delivery_mcp_tools/
   then restart so the skill is picked up.
4. If I decline, skip all of the above and work from the context below alone.

Then run /unblock-pr — it will pull the CI data itself. The job context below is what we already know.

If /unblock-pr is not available — because I declined the setup above, or it did not install — work from the context below instead.

Datadog has already classified this failure as caused by changes in this PR.
Take that as given and work the fix:

1. Locate the change. Diff this branch against its base and find the change
   that produces this error. Explain the mechanism, don't just name a file:
     git fetch origin && git diff $(git merge-base origin/develop HEAD)...HEAD
2. Reproduce it locally. Run the failing job's command or test before
   proposing anything.
3. Propose the smallest fix that addresses the root cause — not a workaround,
   not a broadened assertion, not a disabled or skipped test.
4. Re-run the same command to confirm, and say exactly what you ran.
5. If the failure turns out to be intermittent rather than deterministic, say
   so plainly instead of "fixing" it — that is a flaky test, and patching it
   hides the problem.

If the right move is to re-run the job rather than change code, use the job
link in the context below. For GitHub Actions: `gh run rerun <run-id> --failed`,
where the run ID is the number after `/runs/` in that URL (not the trailing
number, which is the job ID).

Branch: feature/set-file-value-to-env-var-value

build | tide_build
Commit: 41b9df5aa199b5bc6b400f53a16839d731ac5aa5
Error (code / quality):
Exceeds line length limit: Line exceeds 80 characters; contains 81 characters in code.
CI job: https://github.com/dpc-sdp/tide_core/actions/runs/32806873540/job/97678602430

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 41b9df5 | Docs | View more details | Give us feedback!

@nicksantamaria nicksantamaria left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GROwen
GROwen merged commit f9c489f into develop Aug 25, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants