Improve/fix handling of bubbleable metadata in entity_embed

[wimleers]

See https://www.drupal.org/node/2593379.

[davereid]

How is it ok to remove the metadata about the entity itself? Are we assuming that every field formatter that can be re-used to display an embedded entity correctly has this metadata in its render API array?

[davereid]

@wimleers ?

[davereid]

This also looks like we're losing the metadata from the access check.

[wimleers]

We can remove the second line because we are rendering the embedded entity, that will itself include the cacheability metadata of the entity.

[wimleers]

This also looks like we're losing the metadata from the access check.
Why?

[davereid]

LOL, because I couldn't see the very next line:
$result->addCacheableDependency($access);