Use test log storage in test_updates_running_job#4065
Merged
Conversation
No logs written by the test, but an instance of a `LogStorage` implementation is created via `write_logs()` -> `get_log_storage()`, leading to possible side effects, e.g. `CloudWatchLogStorage.__init__()` checks if the log group exists and fails with an error (suppressed, but a warning is still emitted): > UserWarning: A test tried to use socket.socket.connect() with host > "3.250.243.83" (allowed: "127.0.0.1,localhost (127.0.0.1)"). > raise SocketConnectBlockedError(allowed_list, host)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No logs written by the tests, but an instance of a
LogStorageimplementation is created viawrite_logs()->get_log_storage(), leading to possible side effects, e.g.CloudWatchLogStorage.__init__()checks if the log group exists and fails with an error (suppressed, but a warning is still emitted):