Add support for offers with unknown disk size#4066
Open
un-def wants to merge 1 commit into
Open
Conversation
If `InstanceOffer.instance.resources.disk.size_mib` is set to `0`, it's now treated as "disk size is unknown", and such offers are not filtered against `Requirements.resources.disk.size` (as if it's set to `None`); in other words, the `DiskSpec` requirement is simply ignored. The only backend that uses this new feature is Slurm -- there is no notion of persistent disk storage as a consumable resource (unless expressed via GRES, which we don't support), and previously we adjusted offers with fake disk size from the lower limit of the `DiskSpec.size` range, making a false promise that such an amount of storage is available. Now, disk size is always `0` -> isn't displayed to the end user at all, but offers are still not skipped due to disk size min/max requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
InstanceOffer.instance.resources.disk.size_mibis set to0, it's now treated as "disk size is unknown", and such offers are not filtered againstRequirements.resources.disk.size(as if it's set toNone); in other words, theDiskSpecrequirement is simply ignored.The only backend that uses this new feature is Slurm -- there is no notion of persistent disk storage as a consumable resource (unless expressed via GRES, which we don't support), and previously we adjusted offers with fake disk size from the lower limit of the
DiskSpec.sizerange, making a false promise that such an amount of storage is available. Now, disk size is always0-> isn't displayed to the end user at all, but offers are still not skipped due to disk size min/max requirements.