Skip to content

ft: add kyberswap_aggregator_trades for more chains#9201

Closed
NgoKimPhu wants to merge 3 commits intoduneanalytics:mainfrom
KyberNetwork:main
Closed

ft: add kyberswap_aggregator_trades for more chains#9201
NgoKimPhu wants to merge 3 commits intoduneanalytics:mainfrom
KyberNetwork:main

Conversation

@NgoKimPhu
Copy link
Copy Markdown

Description:

add kyberswap_aggregator_trades for: berachain, linea, mantle, ronin, sonic, unichain

@github-actions github-actions Bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Jan 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 11, 2026

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@NgoKimPhu
Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Jan 11, 2026
@NgoKimPhu NgoKimPhu marked this pull request as ready for review January 11, 2026 07:36
@cursor
Copy link
Copy Markdown

cursor Bot commented Jan 11, 2026

PR Summary

Expands KyberSwap aggregator coverage and integrates new chains into the unified trades table.

  • Adds chain-specific models and schemas for berachain, linea, mantle, ronin, sonic, unichain with incremental configs, price joins, start dates, and data tests
  • Updates kyberswap_aggregator/trades.sql to union the new models and extends expose_spells to all supported chains
  • Broadens metadata in _schema.yml (blockchain list, tags) and adds contributor phu_ngo
  • Minor comment/formatting tweaks in existing chain models (e.g., token filter comments)

Written by Cursor Bugbot for commit d8c2efe. Configure here.

@github-actions github-actions Bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 11, 2026
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment @cursor review or bugbot run to trigger another review on this PR

- name: kyberswap_aggregator_trades
meta:
blockchain: avalanche_c, optimism, ethereum, arbitrum, bnb, polygon, base
blockchain: avalanche_c, base, berachain, bnb, ethereum, linea, mantle, optimism, polygon, ronin, sonic, unichain
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arbitrum blockchain missing from metadata and expose_spells

Medium Severity

The arbitrum blockchain was accidentally dropped from the metadata when adding new chains. The blockchain: field in _schema.yml and the expose_spells list in kyberswap_aggregator_trades.sql no longer include arbitrum, but the SQL model still references kyberswap_aggregator_arbitrum_trades in the models array. This creates an inconsistency where arbitrum data is included in the union query but not exposed in the spell metadata, potentially affecting downstream consumers and documentation that rely on these declarations.

Additional Locations (1)

Fix in Cursor Fix in Web

@NgoKimPhu NgoKimPhu marked this pull request as draft January 11, 2026 07:49
@github-actions github-actions Bot added WIP work in progress and removed ready-for-review this PR development is complete, please review labels Jan 11, 2026
@jeff-dude jeff-dude closed this Mar 7, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dbt: dex covers the DEX dbt subproject WIP work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants