ci: restore test suite and build checks in CI#184
Open
duriantaco wants to merge 6 commits into
Open
Conversation
Restore the test, build-dev-binaries, smoke, system, ecosystem, trampoline, zizmor, and release-plan jobs that were detached from ci.yml in the stabilization pass. The plan step already computed gates for all of these; they were simply never invoked, so no tests ran on pull requests or pushes to main. Adaptations for standard GitHub-hosted runners: - Remap org-level larger runner labels (github-ubuntu-24.04-*, github-windows-2025-x86_64-16, macos-latest-large) to public runner labels, and raise timeouts sized for 8-16 core machines. - Bootstrap test Pythons with uv via setup-uv (the previous `fyn python install` step ran before any fyn binary existed) and share the install directory with the test suite through UV_PYTHON_INSTALL_DIR, since fyn's managed directory differs from uv's. bench, test-integration, test-publish, and check-publish remain unwired; they need external services or secrets this fork does not have (noted inline in ci.yml). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # - test-integration: requires credentials for external package registries. | ||
| # - test-publish: requires Astral's test-publish secrets and trusted publishing. | ||
| # - check-publish: crates.io publishing is disabled for fyn (#165). | ||
|
|
The Azure kernel on standard GitHub-hosted runners does not include the minix module; install linux-modules-extra and modprobe it before creating the low-hardlink test filesystem. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
planstep inci.ymlcomputes gates for the full test matrix (test_code,test_smoke,test_ecosystem,test_system,test_macos,test_windows_trampoline, …) but since the stabilization pass (c4437c4) none of those outputs were consumed — the only jobs wired into CI were check-fmt, check-lint, check-docs, and check-generated-files. No tests ran on any pull request or push to main.This PR reconnects the test and build jobs, adapted to run on standard GitHub-hosted runners:
test(cargo nextest on Linux always, macOS/Windows per existing gates),build-dev-binaries,test-smoke,test-system,test-ecosystem,test-windows-trampolines,check-zizmor,check-release,build-release-binaries,build-docker— all gated on the existing plan outputs, and all added torequired-checks-passed(skipped counts as pass, as before).github-ubuntu-24.04-x86_64-8,github-ubuntu-24.04-aarch64-{2,4},github-windows-2025-x86_64-16,macos-latest-large) are not available on a personal repo, so jobs targeting them would queue forever. Remapped toubuntu-latest,ubuntu-24.04-arm,windows-latest, andmacos-15-intel, with timeouts raised to fit 4-core machines.fyn python installimmediately after installing uv via setup-uv — rename fallout; nofynbinary exists at that point. Now bootstraps withuv python installand shares the interpreter directory with the test suite viaUV_PYTHON_INSTALL_DIR(fyn's managed-Python directory differs from uv's, so without this the test harness would not find the bootstrapped interpreters).Test plan
whysuite 8/8).This PR is generated with Claude Code