test maps#18
Draft
mhmd-azeez wants to merge 2 commits intomainfrom
Draft
Conversation
nilslice
reviewed
Oct 23, 2024
| pdk.SetError(err) | ||
| return 0 | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Now that we link the test imports (e.g. assert, etc) into XTP Tests, I wonder if it would be worthwhile to run assertions on the kv pairs, doing a type assertion inside the mock here too?
e.g.
import (
xtptest "github.com/dylibso/xtp-test-go"
)
...
a, ok := obj["keyFromJs"].(int)
xtptest.AssertEq("reflectMapHost preserved map int value", a, 42)
...
Member
There was a problem hiding this comment.
I think this should work, assuming all the xtp CLI PRs are merged and the latest version is relased
nilslice
reviewed
Oct 23, 2024
| return 0 | ||
| } | ||
|
|
||
| fmt.Println(k) |
Member
There was a problem hiding this comment.
From an older commit, but does this Println need to be here?
nilslice
reviewed
Oct 23, 2024
| if err != nil { | ||
| pdk.SetError(err) | ||
| return 0 | ||
| } |
Member
There was a problem hiding this comment.
Same comment as above re: adding the tests for type conversion / assertion now that the test module imports are linked.
Contributor
|
converted to draft until we finish refactor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to https://github.com/dylibso/xtp/pull/852