feat: support required fields (make the others optional)#17
Merged
Conversation
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
evacchi
commented
Feb 19, 2025
Contributor
Author
|
related dylibso/mcp.run-servlets#59 |
Contributor
Author
|
IIRC @nilslice mentioned we'll need to release https://github.com/dylibso/xtp-bindgen-test/ for the CI to pass |
Member
|
oh yea, feel free to release the dependent library and re-run these tests. Don't let me be a blocker on these, if the tests pass we can push it along |
Contributor
Author
|
it looks like the test is failing either the test or the mock... 🤔 |
Member
|
what's the status here? I keep getting reminders but don't know who's on this now (re: test suite etc) |
Contributor
Author
|
it's still me I guess |
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
55a39ec to
4418c74
Compare
Contributor
Author
|
ok making some progress here
|
Member
|
@evacchi - ok thanks, can you be sure to link this issue to the GitHub ticket to track the JS PDK bug with whatever info you have on it? |
Contributor
Author
|
@zshipko fixed the issue, we can merge this and close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isZigOptional(schema, property), checking whether the field is nullable OR it is not declared as required in the parent schema.requires dylibso/xtp-bindgen-test#28
Result, e.g.: