feat(prefer-slice-over-split-index): add rule#137
Merged
Conversation
43081j
reviewed
Jun 28, 2026
1db02c1 to
e03b1da
Compare
43081j
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
prefer-slice-over-split-indexto reportsplit(<string>)[0]andsplit(<string>)[1]when only one piece is needed.The rule targets non-empty string separators and skips regex separators, unknown separators, empty-string splits, and split limits that change the indexed result.
This is opt-in only and is not enabled in the recommended/performance config by default.
A quick benchmark on Node 24 showed equivalent
indexOf()/slice()forms were roughly 3x-4.5x faster thansplit()[0|1].Verification
npm test -- src/rules/prefer-slice-over-split-index.test.tsnpm run lintnpm run buildnpm test