feat(prefer-charcode-at-in-loop): add rule#138
Merged
Conversation
8c89460 to
6fe5710
Compare
43081j
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prefer-charcode-at-in-loopcharCodeAt(index)against the numeric code unit instead of comparing one-character stringsNotes
This is suggestion-only and not part of the recommended config. It intentionally keeps unknown indexed access valid unless the receiver is a string literal/template or has string type information.
Node
v24.9.0benchmark on consumer-shaped loops:759.7ms,charCodeAtcompare660.9ms14.7ms,charCodeAtcompare13.4msTest plan
npm test -- src/rules/prefer-charcode-at-in-loop.test.tsnpm run lintnpm run build