refactor: use _hash instead of -hash in GCS path#23
Closed
ValentaTomas wants to merge 1 commit into
Closed
Conversation
Matches fc-versions naming (e.g. v1.14.1_458ca91), so the convention is consistent across firecracker and kernel artifacts: vmlinux-<version>_<short_hash>/<arch>/vmlinux.bin
PR SummaryLow Risk Overview Anything already uploaded under the old dash-separated prefix will not be found/used by the updated path unless downstream tooling is updated to match. Reviewed by Cursor Bugbot for commit fdb81fb. Bugbot is set up for automated code reviews on this repo. Configure here. |
Member
Author
|
Folding into #22 — the underscore change rides along with the bash 3.2 fix there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the kernel GCS path with fc-versions' `_<short_hash>` convention (e.g. `v1.14.1_458ca91`):
```
gs:///vmlinux-_<short_hash>//vmlinux.bin
```
3 spots touched: script header comment + the `dst=` line in `scripts/upload-release-to-gcs.sh` + the README example.
Verified with `--dry-run`:
```
WOULD vmlinux-6.1.102-amd64.bin -> gs://e2b-staging-fc-kernels/vmlinux-6.1.102_c1a568c/amd64/vmlinux.bin
```
Note: anything already uploaded with the old dash path is not auto-renamed; future uploads use the underscore.