validate: ignore cla-bot status when gating release builds#21
Conversation
The release workflow calls check_ci_status() to refuse builds when upstream CI is red. cla-bot reports verification/cla-signed via the legacy commit-status API and that status is permanently red on every direct-mem / hint backport branch in e2b-dev/firecracker because the backports carry commits authored by upstream maintainers we don't have a CLA for (ilstam, ShadowCurse, JackThomson2, Manciukic, zulinx86). Those contributors aren't going to sign our CLA, so the status will stay red and we still need to ship those builds. Filter IGNORED_STATUS_CONTEXTS out of the combined-status response and recompute the rollup. Real CI failures alongside the CLA failure still block (test covers it). IGNORED_CHECK_NAMES gives a parallel knob for the Checks API if a check-run-based bot ever ends up in the same spot.
PR SummaryMedium Risk Overview The new GitHub API calls use leading-slash endpoints (unlike other calls in the file), which may break Reviewed by Cursor Bugbot for commit 443e71c. Bugbot is set up for automated code reviews on this repo. Configure here. |
Summary
check_ci_status()in the release workflow refuses to build when upstream CI is red. cla-bot publishesverification/cla-signedvia the legacy commit-status API and that status is permanently failing on every direct-mem / hint backport branch ine2b-dev/firecracker(e.g. PR #8) because the backport commits are authored by upstream maintainers we don't have a CLA for (ilstam, ShadowCurse, JackThomson2, Manciukic, zulinx86). Those contributors aren't going to sign our CLA, so we need a way to ship the build anyway.This PR filters an
IGNORED_STATUS_CONTEXTSset (currently justverification/cla-signed) out of the combined-status response before rolling up pass/fail/pending. Real CI failures alongside the CLA failure still block — covered by a regression test.IGNORED_CHECK_NAMESis the parallel knob for the Checks API if a check-run-based bot ever lands in the same situation.Test plan
statuses-array fallback → unchanged).release.ymlagainst thefirecracker-v1.14-direct-membranch's HEAD and confirm it gets past the validate step.