fix(auth): skip expected missing-header telemetry#2645
Draft
tvi wants to merge 1 commit into
Draft
Conversation
Missing auth headers are a normal unauthorized path, so avoid reporting ErrNoAuthHeader as an error while preserving telemetry for unexpected header parsing failures.
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 1c01dff. Bugbot is set up for automated code reviews on this repo. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1c01dff. Configure here.
| ) | ||
| if !errors.Is(err, ErrNoAuthHeader) { | ||
| telemetry.ReportError(ctx, | ||
| "authorization header is missing", |
There was a problem hiding this comment.
Telemetry message misleading after conditional skip
Low Severity
The telemetry.ReportError message "authorization header is missing" now only fires for ErrInvalidAuthHeader (malformed header), since ErrNoAuthHeader is explicitly excluded by the new guard. The telemetry event description no longer matches the actual error condition — it will misleadingly report "missing" when the header was present but malformed.
Reviewed by Cursor Bugbot for commit 1c01dff. Configure here.
❌ 4 Tests Failed:
View the full list of 7 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The telemetry message "authorization header is missing" is incorrect because the logic now ensures the error is not ErrNoAuthHeader. The message should be updated to "authorization header is invalid" to correctly reflect the state when ErrInvalidAuthHeader is returned.
| ) | ||
| if !errors.Is(err, ErrNoAuthHeader) { | ||
| telemetry.ReportError(ctx, | ||
| "authorization header is missing", |
Contributor
There was a problem hiding this comment.
The telemetry message "authorization header is missing" is incorrect because the preceding check ensures the error is not ErrNoAuthHeader. The message should be updated to "authorization header is invalid" to correctly reflect the state when ErrInvalidAuthHeader is returned.
Suggested change
| "authorization header is missing", | |
| "authorization header is invalid", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing auth headers are a normal unauthorized path, so avoid reporting ErrNoAuthHeader as an error while preserving telemetry for unexpected header parsing failures.