Skip to content

2.9.2 114 employees change pass#166

Open
BeHuK wants to merge 44 commits into
easterism:2.9.2from
BeHuK:2.9.2_114_employees_change_pass
Open

2.9.2 114 employees change pass#166
BeHuK wants to merge 44 commits into
easterism:2.9.2from
BeHuK:2.9.2_114_employees_change_pass

Conversation

@BeHuK
Copy link
Copy Markdown
Contributor

@BeHuK BeHuK commented Apr 10, 2026

No description provided.

n2ref and others added 30 commits October 7, 2025 15:17
# Conflicts:
#	inc/classes/OpenApiSpec.php
# Conflicts:
#	inc/classes/OpenApiSpec.php
# Conflicts:
#	inc/classes/OpenApiSpec.php
@roomote-v0
Copy link
Copy Markdown

roomote-v0 Bot commented Apr 10, 2026

Rooviewer Clock   See task

I've reviewed this PR containing 30 commits with various bug fixes and improvements. Overall, the code quality is reasonable with appropriate fixes for SQL errors, display issues, and enhancements to API documentation generation.

Review Summary

Key Changes:

  • Fixed SQL column name bug in LDAP authentication (idu_id)
  • Improved checkbox2 control with "select all" functionality
  • Enhanced OpenAPI schema generation with better module support
  • Added custom sequence interface for drag-and-drop sorting
  • Fixed import field template assignment
  • Added getFilesNormalize() method for file upload handling
  • Improved error messages for missing API endpoints

Potential Issues:

While most changes are solid improvements, there's one potential issue worth noting:

In inc/classes/OpenApiSpec.php around lines 254-259, the variable $schema is accessed outside its definition scope. The variable is only defined inside the if (file_exists($controller_path)) block (line 246), but lines 254-259 attempt to use it unconditionally. This could cause an "Undefined variable" error if the controller file doesn't exist. Consider initializing $schema = [] before line 232 to prevent this issue.

Recommendation: ✅ Approve with minor suggestion to initialize $schema variable.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants