scrollbar and scrollindicator size and color updates#41
Open
scrollbar and scrollindicator size and color updates#41
Conversation
seventil
added
[scope] enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These PR addresses the EaElements ScrollBar and ScrollIndicator.
They colors were using references to control.Material and I tried updating them to EaStyles colors.
The size of the scrollbar changed to smaller, which fits nicely with other EaStyles.
I also added a slight radius as the buttons seem to have.
Also added TopPadding and TopInset for the ScrollBar and the ScrollIndicator: with our tableviews having
showHeader: trueandheaderPositioning: ListView.OverlayHeadersnapping the scrollbar and scrollindicators top sides to the header just makes sense. But this seems too much tied to current TableView implementation, so I'm not sure.Free scrollBar:
Active scrollBar:
Hover scrollBar
scrollIndicator
