Add get_all_variables method to EasyList for collection querying#242
Open
Add get_all_variables method to EasyList for collection querying#242
Conversation
rozyczko
added
[scope] enhancement
damskii9992
reviewed
May 5, 2026
Contributor
damskii9992
left a comment
damskii9992
left a comment
There was a problem hiding this comment.
Looks good. Nice and simple and short :) Few comments to further improve it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
get_all_variablesmethod to EasyList to enable proper querying of collections.This removes the requirement of having a dedicated Collections-type class, as EasyList is already a collection.