Skip to content

Move ObjBase and CollectionBase to legacy. Added deprecation message#245

Merged
rozyczko merged 4 commits intoeasylist_extendedfrom
obsolete_classes
May 6, 2026
Merged

Move ObjBase and CollectionBase to legacy. Added deprecation message#245
rozyczko merged 4 commits intoeasylist_extendedfrom
obsolete_classes

Conversation

@rozyczko
Copy link
Copy Markdown
Member

@rozyczko rozyczko commented May 6, 2026

This pull request deprecates the CollectionBase and ObjBase classes in easyscience.base_classes, moving them to easyscience.legacy. All direct imports and usages of these classes have been updated to reference the new legacy location, and deprecation warnings have been added.

@rozyczko rozyczko added [scope] enhancement Adds/improves features (major.MINOR.patch) [priority] high Should be prioritized soon labels May 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 96.05911% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.65%. Comparing base (64dba93) to head (62f7812).

Files with missing lines Patch % Lines
src/easyscience/legacy/collection_base.py 97.65% 3 Missing ⚠️
src/easyscience/job/analysis.py 0.00% 1 Missing ⚠️
src/easyscience/job/experiment.py 0.00% 1 Missing ⚠️
src/easyscience/job/job.py 0.00% 1 Missing ⚠️
src/easyscience/job/theoreticalmodel.py 0.00% 1 Missing ⚠️
src/easyscience/legacy/obj_base.py 98.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           easylist_extended     #245      +/-   ##
=====================================================
- Coverage              86.65%   82.65%   -4.00%     
=====================================================
  Files                     55       62       +7     
  Lines                   4698     4947     +249     
=====================================================
+ Hits                    4071     4089      +18     
- Misses                   627      858     +231     
Flag Coverage Δ
integration 43.58% <48.27%> (-2.14%) ⬇️
unittests 81.38% <96.05%> (-3.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyscience/__init__.py 100.00% <100.00%> (ø)
src/easyscience/base_classes/__init__.py 100.00% <100.00%> (ø)
src/easyscience/base_classes/collection_base.py 100.00% <100.00%> (+3.96%) ⬆️
src/easyscience/base_classes/obj_base.py 100.00% <100.00%> (+5.26%) ⬆️
src/easyscience/legacy/__init__.py 100.00% <100.00%> (ø)
src/easyscience/job/analysis.py 0.00% <0.00%> (ø)
src/easyscience/job/experiment.py 0.00% <0.00%> (ø)
src/easyscience/job/job.py 0.00% <0.00%> (ø)
src/easyscience/job/theoreticalmodel.py 0.00% <0.00%> (ø)
src/easyscience/legacy/obj_base.py 98.30% <98.30%> (ø)
... and 1 more

... and 4 files with indirect coverage changes

@rozyczko rozyczko requested a review from damskii9992 May 6, 2026 13:20
Copy link
Copy Markdown
Contributor

@damskii9992 damskii9992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rozyczko rozyczko merged commit 5bd3208 into easylist_extended May 6, 2026
28 of 29 checks passed
@rozyczko rozyczko deleted the obsolete_classes branch May 6, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] high Should be prioritized soon [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants