chore: schedule recurring jobs for scanning only when necessary#1840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, various scanning related jobs where always scheduled with the
@Recurringannotation.However, these jobs should only be scheduled and executed when scanning is actually enabled.
This PR cleans this up with a
ScheduleScanningJobcomponent that runs when the application started up and schedules the job only when necessary. The jobs are deleting when scanning is disabled.Also the GitLeaks job did hard-code the schedule instead of using the value from the config, that was also fixed.