Snippet for demonstrating Cropping and Scaling of GC#drawImage #2912
+178
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merks
reviewed
Dec 26, 2025
| * are made available under the terms of the Eclipse Public License 2.0 | ||
| * which accompanies this distribution, and is available at | ||
| * https://www.eclipse.org/legal/epl-2.0/ | ||
| * Copyright (c) 2000, 2016 IBM Corporation and others. |
Contributor
There was a problem hiding this comment.
I assume this was (mostly) copied, but even then the date does not reflect date of current content.
Contributor
Author
There was a problem hiding this comment.
Good catch, the header was copied from an existing snippet.
I’ve updated the copyright year to reflect the current content.
al-noori
force-pushed
the
al-noori/SnippetForDrawImage
branch
2 times, most recently
from
5a92e80 to
ebd2b7b
Compare
Contributor
akoch-yatta
reviewed
Dec 29, 2025
Contributor
akoch-yatta
left a comment
akoch-yatta
left a comment
There was a problem hiding this comment.
In general it looks good to me.
I need to test a bit more, but the Screenshot of the snippet and the entry in Snippets.md is missing, have a look e.g. in cf6ee39 to see, what is necessary for a new Snippet
Previously, GC#drawImage was only used in Snippet 10 to demonstrate scaling. Since the method also supports cropping parts of a source image, and scaling itself can be achieved by passing only the destination coordinates/width/height, this commit adds a more expressive snippet (adresses eclipse-platform#565).
al-noori
force-pushed
the
al-noori/SnippetForDrawImage
branch
from
ebd2b7b to
51500ee
Compare
Contributor
Author
|
A preview screenshot and an entry in the snippets.md file are now included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, GC#drawImage was only used in Snippet 10 to demonstrate scaling. Since the method also supports cropping parts of a source image, and scaling itself can be achieved by passing only the destination coordinates/width/height, this PR adds a more expressive snippet (adresses #565).