Fix dark styling for popup shells in workspace selection#3955
Merged
vogella merged 1 commit intoeclipse-platform:masterfrom May 1, 2026
Merged
Conversation
Use display.addFilter instead of addListener for SWT.Show so the listener actually fires for child popup shells (e.g. the content proposal popup in the workspace selection combo). Re-apply styles asynchronously to cover widgets populated after the Show event. Reproducible on Windows; not reproducible on Linux.
Contributor
Author
|
With this fix the completion window in windows is dark otherwise white: 
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
display.addFilterinstead ofaddListenerforSWT.Showso the early dark-theme listener actually fires for child popup shells (e.g. the content-proposal popup in the workspace selection combo).Display.addListeneronly catches events sent to the Display widget itself, not events on child shells — so the listener was previously a no-op for popups.SWT.Show(e.g. theSWT.VIRTUALproposalTablewhose rows are populated lazily).The two existing dark dialogs (workspace selection, version warning) appeared dark only because their
createContents()overrides callapplyDarkStyles(getShell())directly. The content-proposal popup is created by JFace'sContentProposalAdapterwhere we have no such hook, so it stayed light.Reproducible on Windows; not reproducible on Linux.