Skip to content

[#3958] fix key command action handler gets deleted by content assist #3959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merks merged 1 commit into from
May 5, 2026
+5 −0
Merged

[#3958] fix key command action handler gets deleted by content assist #3959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ....ui.workbench.texteditor/src/org/eclipse/ui/texteditor/KeyBindingSupportForAssistant.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,11 @@ public KeyBindingSupportForAssistant(IQuickAssistAssistant quickAssistAssistant)

@Override
public void assistSessionStarted(ContentAssistEvent event) {
// Do not replace commands twice if several processors are registered. This
// method gets called for each processor.
if (fReplacedCommands != null && !fReplacedCommands.isEmpty()) {
return;
}
ICommandService commandService= PlatformUI.getWorkbench().getService(ICommandService.class);
IHandler handler= getHandler(ContentAssistant.SELECT_NEXT_PROPOSAL_COMMAND_ID);
fReplacedCommands= new ArrayList<>(10);
Expand Down
Loading