Feat: Add cr_checker#2
Conversation
Fix copyright Fix reuse copyright findingds Fix linting
| - name: Run cr_checker unit tests | ||
| run: | | ||
| cd cr_checker/tests | ||
| bazel test //... |
There was a problem hiding this comment.
should we run these through bazel?
There was a problem hiding this comment.
So runing them through python / uv instead you mean?
There was a problem hiding this comment.
It's an option. But I do not know what is better.
There was a problem hiding this comment.
It's kind of a viewpoint question?! Is this a bazel repo with cr_checker or is this a repo with tools and they provide a thin bazel execution wrapper.
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
| [cpp,c,h,hpp,trlc,rsl] |
There was a problem hiding this comment.
this is not good c++, but I guess this file is just moved as-is?
| debug (bool, optional): Whether to enable debug mode, providing additional logs. | ||
| Defaults to False. |
There was a problem hiding this comment.
maybe we can delete debug parameter?
| use_memory_map (bool, optional): Whether to use memory mapping for large files to | ||
| improve performance. Defaults to False. |
There was a problem hiding this comment.
Either this increases performance (default true) or it can be deleteted
There was a problem hiding this comment.
I can not say what exactly this does. I do not see it having any effect in the code whatsoever. It just gets passed around.
@nradakovic do you remember what this parameter does or if it even was fully implemented?
There was a problem hiding this comment.
Generally speaking mmap is faster than reading files. At least that was the case some years ago. (In some situations?)
2 participants
Moving
cr_checkerfrom the tooling repository.To start the splitting up process of the tooling repo.
This still has a dependency to tooling as
python_basicshas not been moved yet.This will be independed once that is done too.