-
Notifications
You must be signed in to change notification settings - Fork 2.7k
16466: clarify role of Orchestrator agent in Theia AI chat interactions #16663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5b21066 to
d6bb543
Compare
|
I've rebased the PR on the current master, which included a refactoring of the Welcome Page from regular React to (Localized)Markdown: issues/16470 |
ndoschek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CamilleLetavernier, thanks for this improvement, the flow works great and will guide new users much better now! 🙌
I added a few minor comments inline and have one general thought:
The views could be aligned in a follow-up so they all use consistent headings and layout. The first and default view weren't touched by this PR, so handling it separately should be fine imo. When testing the new user flow, the views switch between different styles, fonts, sizes, and alignments, which feels a bit jumpy to the eye.
packages/ai-ide/src/browser/ide-chat-welcome-message-provider.tsx
Outdated
Show resolved
Hide resolved
packages/ai-ide/src/browser/ide-chat-welcome-message-provider.tsx
Outdated
Show resolved
Hide resolved
packages/ai-ide/src/browser/ide-chat-welcome-message-provider.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I would like to double check the font sizes, margins and so on and use theia css variables where possible, but as mentioned in my general comment, it would also be fine for me to rework the styling in a follow up together with the other views we have.
|
@JonasHelming could you also take a look at the flow in general and let us know if you’re fine with it or have any additional feedback? TIA! |
|
Thanks, this is a nice improvement for initial users!
I think we should make the message feel less like an exception, as users will very likely run into it. Suggestion: Please configure at least one language model providerIf you want to use OpenAI, Anthropic or GoogleAI hosted models, please enter an API key in the settings. (maybe link the provider names to their settings page) Current Configuration Statemessage from providers |
- ensure at least one language model is configured (e.g. API Key present) - report configuration errors for language models, to help the user identify what they need to do - unset the Ollama default models (not relevant defaults; also makes it impossible to distinguish whether ollama is actually configured) - remove the fallback "Default Agent" - make sure the user explicitly selects its own "Default Agent" (with some recommendations) - improve error messages when using an invalid/disabled Agent
6761e40 to
2f8efa5
Compare
|
I've rebased the PR to main and addressed most of the review comments. In the meantime, the AI Configuration view was rewritten quite significantly, and I believe it introduced a regression, as the Welcome Message Provider was no longer notified when agents were enabled/disabled. I've patched the agent-service accordingly (it's not directly related to this PR; but I need this notification mechanism to track configuration changes and properly refresh the Welcome message).
This PR only removed the default agent, but didn't change anything about the Orchestrator itself. The Agent (and its settings) still exist.
The Config warning message will go away if at least one provider is "properly" configured; and some providers are fully (or almost fully) configured out of the box (e.g. Ollama with its default values). So you also need to remove e.g. all Ollama models to see this configuration screen.
👍 |
ndoschek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks a lot for the updates @CamilleLetavernier!
I added a few notes to the follow-ups as discussed offline.
I also noticed a small issue with updating the language models: if all Google models are removed and then the defaults are restored, no update is triggered, but this is a known problem outside the scope of this PR, and we already planned to address it next month, so no action needed here (see also #16645)
Works great for me, approved from my side 🎉
What it does
How to test
Screen 1: AI Features are disabled (Not change for this screen)
Screen 2: AI Models are not configured (New screen 🌟 )
Screen 3: Default Agent has not been selected (New screen 🌟 )
Screen 4: Everything is (probably) fine, happy chatting! (No change for this screen)
Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers