-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Adds breakpoint actions to debug view #16700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Implements breakpoint actions (edit, remove) to the debug view, including data, function, instruction and source breakpoints. This provides users with a more intuitive way to manage breakpoints.
413d467 to
2f8841c
Compare
ndoschek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sgraband thanks a lot, this is a great improvement! 👍
I tested it and everything works well for the different breakpoint types. I added a few minor inline comments, and I noticed two issues:
After startup/reload, the first click on Edit does not work and triggers the following error. A second click works, and selecting the breakpoint first before clicking Edit also works.
command.ts:345 Uncaught (in promise) Error: The command 'debug.breakpoint.edit' cannot be executed. There are no active handlers available for the command.
at CommandRegistry.executeCommand (command.ts:345:29)
at DebugSourceBreakpoint.onEdit (debug-source-breakpoint.tsx:169:29)
For the Uncaught/Caught Exceptions entries, it would be helpful to include the Edit Breakpoint action in the context menu as well. It also seems worth checking whether the current context menu entries are needed in this case. VS Code exposes the edit action for exception breakpoints, and it feels more intuitive there.
Would be great if you could have a look when you have some time, TIA!
packages/debug/src/browser/debug-frontend-application-contribution.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Graband <[email protected]>
Signed-off-by: Simon Graband <[email protected]>
Previous implementation did not work very well and was overly complex. Signed-off-by: Simon Graband <[email protected]>
Signed-off-by: Simon Graband <[email protected]>
Signed-off-by: Simon Graband <[email protected]>
|
Thank you for the updates @sgraband! 👍 I just noticed one further issue (not sure if it's new though): |
What it does
Implements breakpoint actions (edit, remove) to the debug view, including data, function, instruction and source breakpoints. This provides users with a more intuitive way to manage breakpoints.
How to test
Try out the new buttons in the Breakpoints view and test if they work as expected.
Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers