Skip to content

Conversation

@sgraband
Copy link
Contributor

@sgraband sgraband commented Dec 3, 2025

What it does

Implements breakpoint actions (edit, remove) to the debug view, including data, function, instruction and source breakpoints. This provides users with a more intuitive way to manage breakpoints.

How to test

image

Try out the new buttons in the Breakpoints view and test if they work as expected.

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Dec 3, 2025
Implements breakpoint actions (edit, remove) to the debug view,
including data, function, instruction and source breakpoints.
This provides users with a more intuitive way to manage breakpoints.
@sgraband sgraband force-pushed the sg/breakpoint-actions branch from 413d467 to 2f8841c Compare December 3, 2025 11:01
@ndoschek ndoschek self-requested a review December 3, 2025 12:17
Copy link
Member

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sgraband thanks a lot, this is a great improvement! 👍

I tested it and everything works well for the different breakpoint types. I added a few minor inline comments, and I noticed two issues:

After startup/reload, the first click on Edit does not work and triggers the following error. A second click works, and selecting the breakpoint first before clicking Edit also works.

command.ts:345 Uncaught (in promise) Error: The command 'debug.breakpoint.edit' cannot be executed. There are no active handlers available for the command.
    at CommandRegistry.executeCommand (command.ts:345:29)
    at DebugSourceBreakpoint.onEdit (debug-source-breakpoint.tsx:169:29)

For the Uncaught/Caught Exceptions entries, it would be helpful to include the Edit Breakpoint action in the context menu as well. It also seems worth checking whether the current context menu entries are needed in this case. VS Code exposes the edit action for exception breakpoints, and it feels more intuitive there.

Image

Would be great if you could have a look when you have some time, TIA!

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Waiting on author in PR Backlog Dec 4, 2025
Signed-off-by: Simon Graband <[email protected]>
Previous implementation did not work very well and was overly complex.

Signed-off-by: Simon Graband <[email protected]>
Signed-off-by: Simon Graband <[email protected]>
Signed-off-by: Simon Graband <[email protected]>
@sgraband sgraband requested a review from ndoschek December 8, 2025 10:56
@ndoschek
Copy link
Member

ndoschek commented Dec 9, 2025

Thank you for the updates @sgraband! 👍

I just noticed one further issue (not sure if it's new though):
While the session is running, the edit action does not work and logs the following error, the delete action works though.
As soon as i terminate the session the edit also works again as expected.

debug-source-breakpoint.tsx:170 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'executeCommand')
    at DebugSourceBreakpoint.onEdit (debug-source-breakpoint.tsx:170:29)

@ndoschek ndoschek mentioned this pull request Dec 9, 2025
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting on author

Development

Successfully merging this pull request may close these issues.

3 participants