Skip to content

Fixed the Studio view test comparing goldens at the wrong offset #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fdesbiens merged 1 commit into from
Aug 27, 2026
Merged

Fixed the Studio view test comparing goldens at the wrong offset #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions test/guix_studio_test/test_view/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
# https://opensource.org/licenses/MIT.
#
# SPDX-License-Identifier: MIT
# Some portions generated by Claude Code (Opus 5).

import os
import sys
Expand Down Expand Up @@ -217,15 +218,19 @@ def compare_file(pathname_1, pathname_2, encoding = "", compare_start_string = "
start_row_2 = 0

if compare_start_string != "":
# find the line where comparing starts
# Find the line where comparing starts, independently in each file. The
# two files may reach that line at different offsets -- a generated file
# carries the Studio banner, while the golden checked in beside it also
# carries a licence header -- so each start row must be looked up in its
# own list.
for line in list_1:
if compare_start_string in line:
start_row_1 = list_1.index(line)
break;

for line in list_2:
if compare_start_string in line:
start_row_2 = list_1.index(line)
start_row_2 = list_2.index(line)
break;

# compare from the start line
Expand Down
Loading