feat: support multiline/block comments for C/C++#1004
Closed
ghentschke wants to merge 1 commit into
Closed
Conversation
Fixes eclipse-tm4e#1003 Extending the onEnterRules
Contributor
Author
|
I am not sure if and which unit tests should be updated |
Member
|
The syntax and language configuration files are sourced directly from vscode repo. We do not modify upstream files in tm4e. If I would merge this, the changes would be gone the next time we sync with vscode. So this change should be better made in the source repo. Either at https://github.com/microsoft/vscode/tree/main/extensions/cpp or even in https://github.com/jeff-hykin/better-cpp-syntax |
Contributor
Author
|
Thanks for the feedback. It seems that the configuration comes from vscode. Haven't found any language-configuration.json or something similar in the jeff-hykin repo. |
Contributor
Author
|
Closed as it has to be fixed in vscode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1003
Extending the onEnterRules