Closed
Conversation
Contributor
|
Great @tundewey @ed-donner This is ready to be merged. |
Owner
|
apols, but I can't review 7,500 loc across 54 files..
|
Contributor
Author
|
Owh, I think I know what went wrong. My PR's were all stacked on their
branches.
I guess I've successfully fixed them by creating new branches and doing it
right.
…On Tue, Mar 31, 2026 at 11:54 PM Ed Donner ***@***.***> wrote:
*ed-donner* left a comment (ed-donner/agents#1170)
<#1170?email_source=notifications&email_token=AVGUAIULCVIC6LWO7VHT5Z34TRED7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJWGYYTKOJWGUYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4166159650>
apols, but I can't review 7,500 loc across 54 files..
Can I suggest:
1. remove the uv.lock
2. separate into PRs for different submissions
3. Remove jpgs and data
4. typically a submission is a few files and 1,000 loc or less.
—
Reply to this email directly, view it on GitHub
<#1170?email_source=notifications&email_token=AVGUAIULCVIC6LWO7VHT5Z34TRED7A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJWGYYTKOJWGUYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4166159650>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVGUAIUBIFDCAMSWFZMNAU34TRED7AVCNFSM6AAAAACXIH6AAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNRWGE2TSNRVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
@tundewey It's still not cleared and we can't proceed further without it |
Contributor
Author
|
Please disregard this PR. It's the old one. No longer valid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ed-donner
@iamumarjaved
Project Description:
A “habit coach” that talks to a local MCP server so you can log habits, list them, check streaks, and see recent days.