Retain previous share prices on DB when polygon eod prices unavailable#25
Open
samsriram712 wants to merge 1 commit intoed-donner:mainfrom
Open
Retain previous share prices on DB when polygon eod prices unavailable#25samsriram712 wants to merge 1 commit intoed-donner:mainfrom
samsriram712 wants to merge 1 commit intoed-donner:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to market.py and prices.py such that if no market prices are available (holidays/weekends), skip updating it and keep the last known price for the symbol
market.py → skips update when price is not available (None is returned) and preserves last known prices when markets are closed on holidays/weekends. Provides improved observability when no price is available
prices.py → Change price functions to return Optional[float]. Return None if price is not available