-
Notifications
You must be signed in to change notification settings - Fork 4
Streaming join tests #1490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Streaming join tests #1490
Conversation
df45a97 to
e0ab9a6
Compare
LNSD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, check my comments 🙂
tests/src/steps.rs
Outdated
| mod anvil; | ||
| mod clean_dump_location; | ||
| mod dump; | ||
| mod mine; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If mine and reorg are anvil-dependent steps, I would suggest renaming them anvil_mine and anvil_reorg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
Add new YAML test step types for anvil-based integration tests: - `anvil` step: validates anvil fixture is available - `mine` step: mines N blocks on anvil chain - `reorg` step: triggers blockchain reorg with specified depth These steps enable writing streaming join tests with dynamically generated blockchain data from anvil. Includes example test spec `streaming-join-anvil.yaml` that tests a self-join on blocks via parent_hash with incremental streaming.
Add test for INNER JOIN between blocks and transactions tables. Returns empty results since mined blocks have no transactions.
Validates that streaming joins correctly handle blockchain reorganizations: - Mine 5 blocks, take initial join results - Trigger reorg (depth 2), mine 3 new blocks - Verify incremental results reflect reorganized chain
e0ab9a6 to
d53d898
Compare
Address review feedback: since these steps are anvil-dependent, rename them to make the dependency explicit.
Adds some basic integration tests for streaming joins