feat(events producer): create initial dipper-producer crate. add initial events proto#648
feat(events producer): create initial dipper-producer crate. add initial events proto#648cmwhited wants to merge 2 commits into
Conversation
cmwhited
force-pushed
the
chris.whited/feat-producer/initial-crate-with-proto
branch
from
cd0bd84 to
f9c598b
Compare
MoonBoi9001
left a comment
MoonBoi9001
left a comment
There was a problem hiding this comment.
Nice docs inline text documentation Chris, everything looks good to me. TYVM
| // 3. subgraph.indexing.agreement.accepted - Emitted when an Indexer agrees to the indexing request for the Subgraph | ||
| // 4. subgraph.indexing.agreement.request.expired - Emitted when an indexer fails to accept within the time limit | ||
| // 5. subgraph.indexing.agreement.n_indexers_unavailable - Emitted when selection returns fewer candidates than requested | ||
| // 6. subgraph.indexing.agreement.terminated - Emitted if either the Subgraph developer, or Indexer cancel an indexing agreement on a Subgraph. |
There was a problem hiding this comment.
What if the dipper cancels the agreement on the sg? do we also expose that as an event here?
There was a problem hiding this comment.
Yeah we probably should. Like subgraph.indexing.agreement.canceled? what data would it have? is it an onchain tx?
There was a problem hiding this comment.
We can just use subgraph.indexing.agreement.terminated right? So instead of limiting this to only the Subgraph developer, or Indexer cancelling the agreement, then if the dipper cancels the agreement with an indexer (to pick another indexer instead) then we still expose that here.
There was a problem hiding this comment.
Okay perfect. Don't have to change the protobuf then. Thanks 🙏
| // Timestamp of when the Indexing Agreement was terminated | ||
| uint64 terminated_at = 2; | ||
|
|
||
| // 0x address of the entity (developer, indexer, etc) that terminated the agreement |
There was a problem hiding this comment.
I see, dipper can just throw his own address here
MoonBoi9001
added
the
agreement-events
cmwhited
force-pushed
the
chris.whited/feat-producer/initial-crate-with-proto
branch
from
98c254a to
b45f5d8
Compare
2 participants
No description provided.