feat(sync-service): add Postgres concat(VARIADIC text) to shape subset eval#4281
Open
abegehr wants to merge 3 commits intoelectric-sql:mainfrom
Open
feat(sync-service): add Postgres concat(VARIADIC text) to shape subset eval#4281abegehr wants to merge 3 commits intoelectric-sql:mainfrom
abegehr wants to merge 3 commits intoelectric-sql:mainfrom
Conversation
…t eval Register concat with NULL-skipping semantics (empty string when all args are NULL), matching text concat behavior distinct from || with NULL. Tests cover literals, refs, ilike(concat(...)), contrast with ||, and document that concat() is unsupported (no concat/0 overload).
Enhance SQL generator to support variadic concat function, allowing concatenation of multiple elements wrapped in an array. Update tests to verify the correct SQL output for concat with array arguments, ensuring compatibility with existing functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register concat with NULL-skipping semantics (empty string when all args are NULL), matching text concat behavior distinct from || with NULL.
Tests cover literals, refs, ilike(concat(...)), contrast with ||, and document that concat() is unsupported (no concat/0 overload).