Skip to content

Rename NotificationEntry → ListItem #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 2 commits into from
Sep 4, 2026
Merged

Rename NotificationEntry → ListItem #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac21f55
NotificationEntry: use Granite.Bin
danirabbit Sep 4, 2026
2c990ca
Rename NotificationEntry → ListItem
danirabbit Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 data/NotificationEntry.css → data/ListItem.css
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion data/gresource.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<gresources>
<gresource prefix="/io/elementary/wingpanel/notifications">
<file compressed="true">AppEntry.css</file>
<file compressed="true">NotificationEntry.css</file>
<file compressed="true">ListItem.css</file>
<file compressed="true" preprocess="xml-stripblanks">icons/notification.svg</file>
</gresource>
</gresources>
2 changes: 1 addition & 1 deletion meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ shared_module(
meson.project_name(),
'src/Indicator.vala',
'src/Widgets/NotificationsList.vala',
'src/Widgets/NotificationEntry.vala',
'src/Widgets/ListItem.vala',
'src/Widgets/AppEntry.vala',
'src/Widgets/Symbol.vala',
'src/Services/NotificationsMonitor.vala',
Expand Down
2 changes: 1 addition & 1 deletion po/POTFILES
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
src/Indicator.vala
src/Widgets/NotificationsList.vala
src/Widgets/NotificationEntry.vala
src/Widgets/ListItem.vala
src/Widgets/AppEntry.vala
src/Services/NotificationsMonitor.vala
src/Services/Notification.vala
Expand Down
4 changes: 2 additions & 2 deletions src/Widgets/NotificationEntry.vala → src/Widgets/ListItem.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-FileCopyrightText: 2015-2025 elementary, Inc. (https://elementary.io)
*/

public class Notifications.NotificationEntry : Gtk.ListBoxRow {
public class Notifications.ListItem : Granite.Bin {
public signal void remove (Notification notification);

public Notification notification { get; private set; }
Expand Down Expand Up @@ -38,7 +38,7 @@ public class Notifications.NotificationEntry : Gtk.ListBoxRow {
set_css_name ("notification");

var provider = new Gtk.CssProvider ();
provider.load_from_resource ("io/elementary/wingpanel/notifications/NotificationEntry.css");
provider.load_from_resource ("io/elementary/wingpanel/notifications/ListItem.css");

Gtk.StyleContext.add_provider_for_display (
Gdk.Display.get_default (),
Expand Down
6 changes: 3 additions & 3 deletions src/Widgets/NotificationsList.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public class Notifications.NotificationsList : Granite.Bin {
}

private void setup_factory (Object item) {
var notification_entry = new NotificationEntry ();
var notification_entry = new ListItem ();
notification_entry.remove.connect (remove_notification);

((Gtk.ListItem) item).child = notification_entry;
Expand All @@ -137,14 +137,14 @@ public class Notifications.NotificationsList : Granite.Bin {
private void bind_factory (Object item) {
var list_item = (Gtk.ListItem) item;

var notification_entry = (NotificationEntry) list_item.child;
var notification_entry = (ListItem) list_item.child;
notification_entry.bind ((Notification) list_item.item);
}

private void unbind_factory (Object item) {
var list_item = (Gtk.ListItem) item;

var notification_entry = (NotificationEntry) list_item.child;
var notification_entry = (ListItem) list_item.child;
notification_entry.unbind ();
}

Expand Down
Loading