Skip to content

ListHeader: Make sure to use app name, not class name #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 3 commits into from
Sep 6, 2026
+8 −2
Merged

ListHeader: Make sure to use app name, not class name #357

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eccda5e
ListHeader: Make sure to use app name, not class name
ryonakano Sep 6, 2026
702c955
Make sure to update the tooltip when app_name is set
ryonakano Sep 6, 2026
84e5a77
Fix indentation, make sure to use different variable names
ryonakano Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Widgets/ListHeader.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public class Notifications.ListHeader : Granite.Bin {
construct {
var image = new Gtk.Image.from_icon_name ("pan-end-symbolic");

var label = new Granite.HeaderLabel (name) {
var label = new Granite.HeaderLabel (app_name) {
hexpand = true,
size = H3
};
Expand All @@ -65,7 +65,7 @@ public class Notifications.ListHeader : Granite.Bin {
clear_btn_image.add_css_class ("sweep-animation");

var clear_btn_entry = new Gtk.Button () {
tooltip_text = _("Clear all %s notifications").printf (name),
tooltip_text = _("Clear all %s notifications").printf (app_name),
child = clear_btn_image,
has_frame = false
};
Expand All @@ -79,6 +79,12 @@ public class Notifications.ListHeader : Granite.Bin {
child = box;

bind_property ("app-name", label, "label");
bind_property ("app-name", clear_btn_entry, "tooltip-text", DEFAULT,
(binding, _app_name, ref _tooltip_text) => {
_tooltip_text = _("Clear all %s notifications").printf ((string) _app_name);
return true;
},
() => { return false; });

expander.toggled.connect (() => {
headers[app_id] = expander.active;
Expand Down
Loading