Support publicUrl and hiddenSourceMap options - #126
Merged
Conversation
astronomersiva
force-pushed
the
master
branch
from
February 17, 2019 11:33
76f085d to
7c182a8
Compare
rwjblue
reviewed
Mar 6, 2019
rwjblue
left a comment
rwjblue
left a comment
Member
There was a problem hiding this comment.
Generally seems good to me, would you mind adding some info to the README for the new APIs also?
Adding a few others for review...
Contributor
Author
|
Updated the README, thanks for your time @rwjblue! |
Turbo87
approved these changes
Mar 13, 2019
Contributor
Author
|
A gentle reminder @rwjblue. |
Contributor
Author
|
There are issues when using this with fingerprinting enabled for sourcemaps. I have created a PR in broccoli-asset-rewrite to address this. Can someone take a look at it when free? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #125