Require that library manifest and plugins.txt (internal manifest) match.#8
Open
xobes wants to merge 1 commit intoendless-sky:mainfrom
Open
Require that library manifest and plugins.txt (internal manifest) match.#8xobes wants to merge 1 commit intoendless-sky:mainfrom
xobes wants to merge 1 commit intoendless-sky:mainfrom
Conversation
…tch the values in the required plugin manifest, this change seeks to require that the included plugin.txt file and the manifest data are identical.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently, Plugins contain a file
plugins.txtwhich may or may not match the values in the required plugin manifest. This change to the RFC seeks to require that the includedplugin.txtfile and the manifest data contain identical data (e.g. plugin name, version)Relates to endless-sky/endless-sky#12083 and how plugins are loaded for the Plugins panel display versus the Library panel display such that the user is presented with a common plugin name and where the versions of the installed plugins can readily be compared against the available versions in the library.