Add Windows export preset#2182
Open
wjt wants to merge 1 commit into
Open
Conversation
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/add-windows-export-preset/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Annoyingly this needed changes to the version-generator plugin, because
exporting generated this warning:
WARNING: Invalid version number "v0.1.11-72-g29be516f2". The version
number can only contain numeric characters (0-9) and non-consecutive
periods (.).
I changed it so that "application/config/version" is "0.1.12" for the
tag "v0.1.12", and "0.1.11.72" for a build 72 commits ahead of v0.1.11.
The full `git describe --tags` output is now in
"application/config/full_version".
Explicitly qualify the export name with "x86_64". It is possible we will
one day add an arm64 export. Update the Linux export accordingly. Ensure
the target directory exists for both builds
Resolves #2155
35c86d1 to
2ef4861
Compare
Member
Author
|
I tested a build of this on my Asus E406 laptop (a relatively ancient Celeron from about 2018) running Windows 11. It works fine, except for some normal Windows stuff:
@JoniCeceri also tested a build of this preset on their Windows 11 system – also fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Annoyingly this needed changes to the version-generator plugin, because
exporting generated this warning:
I changed it so that "application/config/version" is "0.1.12" for the
tag "v0.1.12", and "0.1.11.72" for a build 72 commits ahead of v0.1.11.
The full
git describe --tagsoutput is now in"application/config/full_version".
Explicitly qualify the export name with "x86_64". It is possible we will
one day add an arm64 export. Update the Linux export accordingly. Ensure
the target directory exists for both builds
Resolves #2155