Skip to content

Add Windows export preset#2182

Open
wjt wants to merge 1 commit into
mainfrom
wjt/add-windows-export-preset
Open

Add Windows export preset#2182
wjt wants to merge 1 commit into
mainfrom
wjt/add-windows-export-preset

Conversation

@wjt
Copy link
Copy Markdown
Member

@wjt wjt commented May 13, 2026

Annoyingly this needed changes to the version-generator plugin, because
exporting generated this warning:

WARNING: Invalid version number "v0.1.11-72-g29be516f2". The version
number can only contain numeric characters (0-9) and non-consecutive
periods (.).

I changed it so that "application/config/version" is "0.1.12" for the
tag "v0.1.12", and "0.1.11.72" for a build 72 commits ahead of v0.1.11.
The full git describe --tags output is now in
"application/config/full_version".

Explicitly qualify the export name with "x86_64". It is possible we will
one day add an arm64 export. Update the Linux export accordingly. Ensure
the target directory exists for both builds

Resolves #2155

@github-actions
Copy link
Copy Markdown

Play this branch at https://play.threadbare.game/branches/endlessm/wjt/add-windows-export-preset/.

(This launches the game from the start, not directly at the change(s) in this pull request.)

Annoyingly this needed changes to the version-generator plugin, because
exporting generated this warning:

    WARNING: Invalid version number "v0.1.11-72-g29be516f2". The version
    number can only contain numeric characters (0-9) and non-consecutive
    periods (.).

I changed it so that "application/config/version" is "0.1.12" for the
tag "v0.1.12", and "0.1.11.72" for a build 72 commits ahead of v0.1.11.
The full `git describe --tags` output is now in
"application/config/full_version".

Explicitly qualify the export name with "x86_64". It is possible we will
one day add an arm64 export. Update the Linux export accordingly. Ensure
the target directory exists for both builds

Resolves #2155
@wjt wjt force-pushed the wjt/add-windows-export-preset branch from 35c86d1 to 2ef4861 Compare May 13, 2026 19:36
@wjt
Copy link
Copy Markdown
Member Author

wjt commented May 14, 2026

I tested a build of this on my Asus E406 laptop (a relatively ancient Celeron from about 2018) running Windows 11. It works fine, except for some normal Windows stuff:

  1. First “Smart App Control blocked an app that may be unsafe”. There was no way to skip this; I had to go to Windows Security and turn off Smart App Control.
PXL_20260514_084018170
  1. Then “Microsoft Defender SmartScreen” was also sad about this unsigned app. Here I pressed “More info” and “Run anyway” to run it.
PXL_20260514_084128730 PXL_20260514_084123465 MP

@JoniCeceri also tested a build of this preset on their Windows 11 system – also fine.

@wjt wjt marked this pull request as ready for review May 14, 2026 08:51
@wjt wjt requested a review from a team as a code owner May 14, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a Windows export template

1 participant