FIX: Handle the VTK 9.7 release - #1419
Merged
Merged
Conversation
Two failures that VTK 9.7.0 caused, both on main and both unrelated to whichever PR happens to be running. The docs render: 9.7 deprecates vtkImageThreshold, and the warning fires inside the C constructor, so with warnings fatal the example render dies as "SystemError: ... returned a result with an exception set". tvtk_segmentation.py cannot move to the replacement vtkImageBinaryThreshold, which does not exist before 9.7, so ignore that one message until the floor catches up. The suites already ignore every "Call to deprecated" message, which is why no test job saw this. The macos-26-intel row: test_trait_with_range crossed its 60 s timeout. It was not stuck -- 9.7 added 208 classes, which took the test from 26.5 s to 32.9 s on the arm runner, and the intel row was already at 57.5 s. get_min_max_value built a fresh VTK object twice per trait, for every trait of every class, which is the whole cost of the test; one object per class instead takes it from 13.5 s to 0.8 s locally. The (class, trait, min, max) tuples it derives are unchanged -- all 91074 of them, including the 2512 that carry a real range. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
This is a fairly trivial |
Member
|
Nice catch and fix to improve the test speed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two failures that VTK 9.7.0 caused, both on main and both unrelated to whichever PR happens to be running. These are not end-user breakages, just stuff that breaks our CIs.
The docs render: 9.7 deprecates vtkImageThreshold, and the warning fires inside the C constructor, so with warnings fatal the example render dies as "SystemError: ... returned a result with an exception set". tvtk_segmentation.py cannot move to the replacement vtkImageBinaryThreshold, which does not exist before 9.7, so ignore that one message until the floor catches up. The suites already ignore every "Call to deprecated" message, which is why no test job saw this.
The macos-26-intel row: test_trait_with_range crossed its 60 s timeout. It was not stuck -- 9.7 added 208 classes, which took the test from 26.5 s to 32.9 s on the arm runner, and the intel row was already at 57.5 s. get_min_max_value built a fresh VTK object twice per trait, for every trait of every class, which is the whole cost of the test; one object per class instead takes it from 13.5 s to 0.8 s locally. The (class, trait, min, max) tuples it derives are unchanged -- all 91074 of them, including the 2512 that carry a real range.