Refactor HyperSync client to use abstracted client interface#1061
Merged
Conversation
The BlockData module was using raw HTTP requests via HyperSyncJsonApi + Rest.fetch while all other queries used the HyperSyncClient. This switches block hash/timestamp queries to use client.get(), leveraging the client's built-in retries, auth handling, and connection pooling. Changes: - Add includeAllBlocks field and typed queryResponse to HyperSyncClient - Rewrite BlockData module to use client.get() instead of Rest.fetch - Update queryBlockData/queryBlockDataMulti signatures to accept ~client - Update callers in HyperSyncSource to pass the existing client instance https://claude.ai/code/session_01GdmmyVikrTScFWYinb8Ba4
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the HyperSync integration to use an abstracted
HyperSyncClient.tinterface instead of passing rawserverUrlandapiTokenparameters throughout the codebase. This improves encapsulation and simplifies the API surface.Key Changes
~serverUrland~apiTokenparameters with a single~client: HyperSyncClient.tparameter inqueryBlockData,queryBlockDataMulti, and related functionsqueryResponseandqueryResponseDatainHyperSyncClient.resto replace the previously opaque typeBlockData.convertResponseto work directly with the new response structure, removing nestedflatMapoperations and simplifying the data extraction logicHyperSyncJsonApi.QueryTypes.postQueryBodytoHyperSyncClient.QueryTypes.queryand fromHyperSyncJsonApi.ResponseTypes.queryResponsetoHyperSyncClient.queryResponseincludeAllBlocksfield toQueryTypes.queryto support querying all blocks in a range regardless of transaction/log relevanceRest.fetchcall with retry logic, delegating to the client'sgetmethodHyperSyncSource.resto pass the client instance instead of individual connection parametersNotable Implementation Details
res.data.blockshttps://claude.ai/code/session_01GdmmyVikrTScFWYinb8Ba4