Fix 173 cram support#174
Merged
Merged
Conversation
- waiting for PR #172 to clear before addressing DELFI
- update docstrings and help texts to indicate 2bit and FASTA are accepted for reference file
- remove erroneous docustrings claiming 2bit support for CRAM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #173
delficlaims CRAM supportSummary
delfiusing existingreference_fileargument, which now accepts FASTA file format.reference_file(FASTA) through allfragmodule functions(
coverage,frag_length,frag_length_bins,frag_length_intervals,wps,multi_wps,cleavage_profile,multi_cleavage_profile) so CRAMfiles can be decoded correctly. Previously
frag_generatorwas never passedthe reference needed by htslib.
--reference-fileCLI flags tofrag-length-bins,frag-length-intervals,wps, andcleavage-profilesubcommands.ReferenceWrappernow auto-creates a missing.faiindex and recognises.fna/.fna.gzextensions, so FASTA files work out of the box for DELFIGC correction without manual indexing.
delfi,end-motifs,interval-end-motifs,breakpoint-motifs, andinterval-breakpoint-motifsto reflect that FASTAis accepted alongside
.2bit.tests/test_cram.pywith equality tests (CRAM matches BAM) forsingle_coverage,frag_length_bins,wps, anddelfi, plus smoke testsfor all remaining functions. All tests skip automatically when
samtoolsisnot on PATH.
Notes
CRAM input requires a FASTA
reference_file..2bitcannot be used sincehtslib requires FASTA for CRAM decoding.