Skip to content

fix(p256): prevent secret serialization in DID document#7

Closed
eqty-devbot wants to merge 1 commit intoeqtylab:mainfrom
eqty-devbot:fix/p256-hide-did-secrets
Closed

fix(p256): prevent secret serialization in DID document#7
eqty-devbot wants to merge 1 commit intoeqtylab:mainfrom
eqty-devbot:fix/p256-hide-did-secrets

Conversation

@eqty-devbot
Copy link
Collaborator

@eqty-devbot eqty-devbot commented Mar 3, 2026

Summary

  • set serialize_secrets to false in P256Signer::new and P256Signer::import
  • ensure generated DID documents do not include private key material
  • keep JOSE formatting behavior unchanged

Why

We should never serialize secrets into DID documents. This change explicitly disables secret serialization for P-256 signer DID document generation.

Notes

  • This supersedes any prior intent to serialize secrets in this code path.

@eqty-devbot eqty-devbot changed the title fix(p256): avoid serializing secrets into DID document fix(p256): prevent secret serialization in DID document Mar 3, 2026
@cameronfyfe
Copy link
Contributor

cameronfyfe commented Mar 3, 2026

😞

@cameronfyfe cameronfyfe closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants