chore(cats): apply the run-20260820T034449Z triage — five FP rules, /test-endpoint coverage, WebhookDelivery example fix - #802
Merged
Conversation
…test-endpoint coverage, WebhookDelivery example fix
Maintainer-approved remediation of the validating campaign's 154 true
positives (zero server bugs / zero 500s / zero undocumented codes):
- Five false-positive rules (90-94): webhook-signature 401s (72),
operator-pinned /test 403s (39), duplicate-group 409s from replayed base
bodies (20), one-shot create_threat_model 409s (13), and huge-offset
conformant-pagination 200s (2). All dry-run validated, zero 5xx matches;
live reclassify suppressed 146, leaving 8 (5 webhook-signature variants
for next-run triage + the 3 example-validation warns fixed below).
- POST /admin/webhooks/subscriptions/{webhook_id}/test gets real coverage:
a third, non-pinned seeded subscription with a per-path refData override
for just the /test path (the global webhook_id is the operator-pinned
subscription, whose guard 403 was all the endpoint ever produced).
- WebhookDelivery's spec example payload now mirrors the handler's exact
test-payload shape, closing the #657-class "Not matching response
schema" warns (CATS validates 2xx bodies against the example, not the
schema; body verified schema-conforming independently).
Signing-hook coverage follow-up for /webhook-deliveries/*: #790.
Refs #608, #657.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MVKNHGpMb8a7tQB5CZPBWS
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer-approved remediation of the validating campaign's 154 true
positives (zero server bugs / zero 500s / zero undocumented codes):
operator-pinned /test 403s (39), duplicate-group 409s from replayed base
bodies (20), one-shot create_threat_model 409s (13), and huge-offset
conformant-pagination 200s (2). All dry-run validated, zero 5xx matches;
live reclassify suppressed 146, leaving 8 (5 webhook-signature variants
for next-run triage + the 3 example-validation warns fixed below).
a third, non-pinned seeded subscription with a per-path refData override
for just the /test path (the global webhook_id is the operator-pinned
subscription, whose guard 403 was all the endpoint ever produced).
test-payload shape, closing the chore(cats): track upstream Endava/cats#206 — CATS validates 2xx responses against
example, notschema#657-class "Not matching responseschema" warns (CATS validates 2xx bodies against the example, not the
schema; body verified schema-conforming independently).
Signing-hook coverage follow-up for /webhook-deliveries/*: #790.
Refs #608, #657.