Skip to content

fix(bme280): fix bme280_read_altitude variable and unit bugs (AEGHB-1440)#677

Open
bkovacki wants to merge 1 commit into
espressif:masterfrom
bkovacki:fix/fix_bme280_read_altitude
Open

fix(bme280): fix bme280_read_altitude variable and unit bugs (AEGHB-1440)#677
bkovacki wants to merge 1 commit into
espressif:masterfrom
bkovacki:fix/fix_bme280_read_altitude

Conversation

@bkovacki
Copy link
Copy Markdown

@bkovacki bkovacki commented Mar 7, 2026

Description

bme280_read_altitude had two bugs that made it always return incorrect results:

  • Pressure was read into the unused temp variable instead of pressure, leaving pressure at 0.0
  • pressure was then divided by 100 again despite bmp280_read_pressure already returning hPa, which would have produced an incorrect altitude even if the first bug were fixed

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 7, 2026

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello bkovacki, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against ed14576

@github-actions github-actions Bot changed the title fix(bme280): fix bme280_read_altitude variable and unit bugs fix(bme280): fix bme280_read_altitude variable and unit bugs (AEGHB-1440) Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant