fix(button): handle GPIO ISR service installation idempotency#700
Open
iyassou wants to merge 1 commit into
Open
fix(button): handle GPIO ISR service installation idempotency#700iyassou wants to merge 1 commit into
iyassou wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The GPIO ISR service installation is idempotent per ESP-IDF documentation.
ESP_ERR_INVALID_STATEindicates the service was already installed by another component, so not a fatal error. This change allowsiot_buttonto coexist withother components that install the ISR service first by treating
ESP_ERR_INVALID_STATEas success inbutton_gpio_set_intr. The existingisr_service_installedstatic flag is retained to avoid redundant calls after initial installation.Related
No similar issues have been raised to my knowledge.
Testing
I haven't ran the test suite.
Checklist
Before submitting a Pull Request, please ensure the following: