Skip to content

fix(button): handle GPIO ISR service installation idempotency#700

Open
iyassou wants to merge 1 commit into
espressif:masterfrom
iyassou:master
Open

fix(button): handle GPIO ISR service installation idempotency#700
iyassou wants to merge 1 commit into
espressif:masterfrom
iyassou:master

Conversation

@iyassou
Copy link
Copy Markdown

@iyassou iyassou commented Apr 16, 2026

Description

The GPIO ISR service installation is idempotent per ESP-IDF documentation. ESP_ERR_INVALID_STATE indicates the service was already installed by another component, so not a fatal error. This change allows iot_button to coexist with
other components that install the ISR service first by treating ESP_ERR_INVALID_STATE as success in button_gpio_set_intr. The existing isr_service_installed static flag is retained to avoid redundant calls after initial installation.

Related

No similar issues have been raised to my knowledge.

Testing

I haven't ran the test suite.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 16, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants