Skip to content

fix(servo): Add missing component requirements#709

Open
meanwhile131 wants to merge 1 commit into
espressif:masterfrom
meanwhile131:servo-fix
Open

fix(servo): Add missing component requirements#709
meanwhile131 wants to merge 1 commit into
espressif:masterfrom
meanwhile131:servo-fix

Conversation

@meanwhile131
Copy link
Copy Markdown

@meanwhile131 meanwhile131 commented Apr 30, 2026

Description

Building examples/motor/servo_control currently fails (both on my machine and a fresh Github Codespaces environment) because the motor/servo component doesn't have all the required components in REQUIRES
Build log: https://gist.github.com/meanwhile131/5b9da50c992071d18938baa58dd21ff1

Adding esp_driver_ledc and esp_driver_gpio to REQUIRES as idf.py build suggested fixes the build.

Testing

Built examples/motor/servo_control and components/motor/servo/test_apps in a clean Github Codespace on latest ESP-IDF (installed via eim install)

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 30, 2026

CLA assistant check
All committers have signed the CLA.

@YanKE01
Copy link
Copy Markdown
Contributor

YanKE01 commented May 3, 2026

Hi, @meanwhile131 ,Thank you very much for your contribution. You can refer to this commit to add some compatibility for the IDF version.

@meanwhile131 meanwhile131 marked this pull request as draft May 3, 2026 09:08
@meanwhile131 meanwhile131 force-pushed the servo-fix branch 2 times, most recently from 3665569 to 1a40b7b Compare May 3, 2026 09:23
Comment thread components/motor/servo/CHANGELOG.md Outdated
@meanwhile131 meanwhile131 marked this pull request as ready for review May 3, 2026 16:17
@YanKE01
Copy link
Copy Markdown
Contributor

YanKE01 commented May 9, 2026

LGTM! @leeebo please add mr tag.

@meanwhile131
Copy link
Copy Markdown
Author

Hi, @meanwhile131 ,Thank you very much for your contribution. You can refer to this commit to add some compatibility for the IDF version.

The README says that the master branch is for IDF >= 5.3. Should we really maintain compatibility with older versions for new changes?

@leeebo
Copy link
Copy Markdown
Collaborator

leeebo commented May 13, 2026

Hi, @meanwhile131 ,Thank you very much for your contribution. You can refer to this commit to add some compatibility for the IDF version.

The README says that the master branch is for IDF >= 5.3. Should we really maintain compatibility with older versions for new changes?

The README document provides guidance on the components of the repository. The specific supported IDF versions are determined by each individual component. Even if a lower IDF version is maintained for a long time for compatibility, it will not be rejected.

@leeebo
Copy link
Copy Markdown
Collaborator

leeebo commented May 13, 2026

sha=1a332f6ada26ed57b7952224b52d828efcd93029

@leeebo leeebo self-assigned this May 13, 2026
@leeebo leeebo self-requested a review May 13, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants