fix(servo): Add missing component requirements#709
Conversation
|
Hi, @meanwhile131 ,Thank you very much for your contribution. You can refer to this commit to add some compatibility for the IDF version. |
3665569 to
1a40b7b
Compare
|
LGTM! @leeebo please add mr tag. |
The README says that the |
The README document provides guidance on the components of the repository. The specific supported IDF versions are determined by each individual component. Even if a lower IDF version is maintained for a long time for compatibility, it will not be rejected. |
|
sha=1a332f6ada26ed57b7952224b52d828efcd93029 |
Description
Building
examples/motor/servo_controlcurrently fails (both on my machine and a fresh Github Codespaces environment) because themotor/servocomponent doesn't have all the required components inREQUIRESBuild log: https://gist.github.com/meanwhile131/5b9da50c992071d18938baa58dd21ff1
Adding
esp_driver_ledcandesp_driver_gpiotoREQUIRESasidf.py buildsuggested fixes the build.Testing
Built
examples/motor/servo_controlandcomponents/motor/servo/test_appsin a clean Github Codespace on latest ESP-IDF (installed viaeim install)Checklist
Before submitting a Pull Request, please ensure the following: