IEP-1758 GH #1451: On Windows the ESP-IDF Manager is not compatible with latest version of EIM

[sigmaaa]

Description

We can safely parse version 2.0 using the existing code and allow users to activate their ESP-IDF in the IDE. The new changes introduced in eim_idf.json 2.0 can be handled separately at a later stage.

Fixes # (IEP-1758)

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

How has this been tested?

Install some esp-idf with latest eim manager and make sure that eim_idf.json version is 2.0. Try to activate and use esp-idf via Espressif-IDE

Test Configuration:

• ESP-IDF Version:
• OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

• Espressif-IDE manager

Checklist

• PR Self Reviewed
• Applied Code formatting
• Added Documentation
• Added Unit Test
• Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

• Chores
  • Updated configuration file version validation threshold to 2.0 with enhanced compatibility for version checking.

[coderabbitai]

Warning

Rate limit exceeded

@sigmaaa has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 1 second before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bab19021-6963-4dc8-8a10-1e291734c962

📥 Commits

Reviewing files that changed from the base of the PR and between a37adf6 and 7f106c2.

📒 Files selected for processing (1)

• bundles/com.espressif.idf.core/src/com/espressif/idf/core/tools/EimIdfConfiguratinParser.java

📝 Walkthrough

Walkthrough

The EIM JSON version constant is updated from "1.0" to "2.0", and the validation logic in the parser is modified to use numeric threshold comparison instead of exact string equality, allowing versions greater than or equal to the valid version to pass.

Changes

Cohort / File(s)	Summary
EIM Version Validation bundles/com.espressif.idf.core/src/com/espressif/idf/core/tools/EimConstants.java, bundles/com.espressif.idf.core/src/com/espressif/idf/core/tools/EimIdfConfiguratinParser.java	Version constant updated from "1.0" to "2.0". Version validation logic refactored from exact string matching to numeric threshold comparison using double parsing, now accepting versions ≥ 2.0 instead of requiring exact equality.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• kolipakakondal
• AndriiFilippov
• alirana01

Poem

🐰✨ A version bump hops into sight,
From one-point-oh to two, what a delight!
No more exact matches, just thresholds we need,
The parser now validates with graceful speed! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: making ESP-IDF Manager compatible with the latest EIM version on Windows.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch IEP-1758

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 21 minutes and 1 second.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@bundles/com.espressif.idf.core/src/com/espressif/idf/core/tools/EimConstants.java`:
- Line 30: The change raised the minimum accepted EIM JSON version to 2.0 which
breaks backward compatibility; revert EIM_JSON_VALID_VERSION in EimConstants
(the String constant EIM_JSON_VALID_VERSION in class EimConstants) to the
previous compatible baseline (e.g., "1.0" or the prior value used before this
change) or implement a version-acceptance check that permits 1.x versions, so
existing eim_idf.json files continue to validate.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fefa0044-7320-41a4-ac25-7fd20e848e21

📥 Commits

Reviewing files that changed from the base of the PR and between aacc821 and a37adf6.

📒 Files selected for processing (2)

• bundles/com.espressif.idf.core/src/com/espressif/idf/core/tools/EimConstants.java
• bundles/com.espressif.idf.core/src/com/espressif/idf/core/tools/EimIdfConfiguratinParser.java

[kolipakakondal]

LGTM

[AndriiFilippov]

@sigmaaa hi

Tested under:
OS: Windows 11 / Mac arm64

LGTM 👍