Native: Extend Keybindings from Chipmunk 3 & Fix Log selection #2547
Merged
Conversation
* Port most of keybindings from Chipmunk 3 to avoid breaking changes on users. * Changes need to keep track on focused table visually and in code so user can apply same keybindings on the focus table without having to duplicate the keybindings for both tables. * Highlight selected table & Remove focus on text input on focusing tables * Support for keeping track to last unconsumed pressed key to support vim like keybindings like `gg` * Consider if bottom panel is visible before requesting to jump to matching logs in search table on main table log selection
* Select logs in attachments now sync the search table and details view * Centralize logic for logs selection.
* Introduce commands on backend service and in session core to get the next/previous indexed logs. * Calculate bookmarks in UI as they are saved there and not expected to be too many. * Implementation for `[, ], j, k` keys
* Tweak shortcuts so we can override them so they have better meanings in bindings help overlay. * Replace rest of bindings that targets each table on its own with shared bindings for the focused table. * Avoid persisting scrolling state on bindings overlay
* Ensure proper using fro modifiers on MacOS * Better handling for jumping between logs when no log is selected * Fixes for multiple selection changes on logs-table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the keybindings from current electron-based chipmunk including:
G,ggand/[,],jandkJump to matching logand in keybindings