Minor fix to preserveBlankLines (plus an IIFE tweak)#340
Open
ishmal wants to merge 3 commits intoestools:masterfrom
ishmal:preserve-blank-fix
Open
Minor fix to preserveBlankLines (plus an IIFE tweak)#340ishmal wants to merge 3 commits intoestools:masterfrom ishmal:preserve-blank-fix
ishmal wants to merge 3 commits intoestools:masterfrom
ishmal:preserve-blank-fix
Conversation
Author
|
Hmm. I inadvertently made 2 Pull Requests out of one. The other one is providing an option to wrap IIFE's in parens. I can split them and re-submit if you need. After these tweeks, I can re-serialize 1800 of our messy source files almost flawlessly. Thanks for a VERY useful project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At line 1714, there is a potential bug, if a Program block has a child with no range attached. This can cause an exception:
This fix simply checks for the existence of a range. Made the same fix for BlockStatement.