Support trees with immediate .start and .end (without .range)#401
Open
GuyLewin wants to merge 7 commits intoestools:masterfrom
Open
Support trees with immediate .start and .end (without .range)#401GuyLewin wants to merge 7 commits intoestools:masterfrom
GuyLewin wants to merge 7 commits intoestools:masterfrom
Conversation
Member
|
I'd like to see integration tests here, not just synthetic unit tests. If you're claiming Acorn creates trees of this form, prove it by showing a failing integration test that is fixed by your change. |
Author
|
@michaelficarra done. Frankly, Acorn is working even without the fix when using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acorn and Meriyah are generating trees that have .start and .end properties without wrapping .range array.
I added support for parsing such trees + tests to check our range usage