[release-3.6] deflakey: TestCompactionHash in integration #19541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should use WithCompactPhysical to wait for compaction to finish,
because 50ms sleep can't guarantee compaction is done.
Based on the log, the defragment is finished before compaction, which is
not expected. This patch is to make sure compaction should be finished
before assertation.
```
=========================== defragment ==============
logger.go:146: 2025-02-27T07:57:18.652Z INFO m0 finished defragment {"member": "m0"}
=====================================================
logger.go:146: 2025-02-27T07:57:18.652Z INFO m0 grpc service status changed {"member": "m0", "service": "", "status": "SERVING"}
logger.go:146: 2025-02-27T07:57:18.653Z INFO grpc [[core] [Channel etcd-io#1457]Channel Connectivity change to SHUTDOWN]
logger.go:146: 2025-02-27T07:57:18.653Z INFO grpc [[core] [Channel etcd-io#1457]Closing the name resolver]
logger.go:146: 2025-02-27T07:57:18.653Z INFO grpc [[core] [Channel etcd-io#1457]ccBalancerWrapper: closing]
logger.go:146: 2025-02-27T07:57:18.653Z INFO grpc [[core] [Channel etcd-io#1457 SubChannel etcd-io#1458]Subchannel Connectivity change to SHUTDOWN]
logger.go:146: 2025-02-27T07:57:18.653Z INFO grpc [[core] [Channel etcd-io#1457 SubChannel etcd-io#1458]Subchannel deleted]
logger.go:146: 2025-02-27T07:57:18.654Z INFO grpc [[transport] [client-transport 0xc00237bd48] Closing: rpc error: code = Canceled desc = grpc: the client connection is closing]
logger.go:146: 2025-02-27T07:57:18.654Z INFO grpc [[transport] [client-transport 0xc00237bd48] loopyWriter exiting with error: rpc error: code = Canceled desc = grpc: the client connection is closing]
logger.go:146: 2025-02-27T07:57:18.654Z INFO grpc [[transport] [server-transport 0xc0006bb520] Closing: EOF]
logger.go:146: 2025-02-27T07:57:18.654Z INFO grpc [[core] [Channel etcd-io#1457]Channel deleted]
logger.go:146: 2025-02-27T07:57:18.654Z INFO grpc [[transport] [server-transport 0xc0006bb520] loopyWriter exiting with error: transport closed by client]
hash.go:82:
Error Trace: /home/prow/go/src/github.com/etcd-io/etcd/server/storage/mvcc/testutil/hash.go:82
/home/prow/go/src/github.com/etcd-io/etcd/server/storage/mvcc/testutil/hash.go:44
Error: Not equal:
expected: testutil.KeyValueHash{Hash:0x94694091, CompactRevision:1278, Revision:2507}
actual : testutil.KeyValueHash{Hash:0x58af47dc, CompactRevision:2488, Revision:2507}
Diff:
--- Expected
+++ Actual
@@ -1,4 +1,4 @@
(testutil.KeyValueHash) {
- Hash: (uint32) 2489925777,
- CompactRevision: (int64) 1278,
+ Hash: (uint32) 1487882204,
+ CompactRevision: (int64) 2488,
Revision: (int64) 2507
Test: TestCompactionHash
Messages: hashes do not match on rev 2488
cluster.go:1423: ========= Cluster termination started =====================
logger.go:146: 2025-02-27T07:57:18.655Z INFO grpc [[core] [Channel etcd-io#1377]Channel Connectivity change to SHUTDOWN]
logger.go:146: 2025-02-27T07:57:18.655Z INFO grpc [[core] [Channel etcd-io#1377]Closing the name resolver]
logger.go:146: 2025-02-27T07:57:18.655Z INFO grpc [[core] [Channel etcd-io#1377]ccBalancerWrapper: closing]
logger.go:146: 2025-02-27T07:57:18.656Z INFO grpc [[core] [Channel etcd-io#1377 SubChannel etcd-io#1378]Subchannel Connectivity change to SHUTDOWN]
logger.go:146: 2025-02-27T07:57:18.656Z INFO grpc [[core] [Channel etcd-io#1377 SubChannel etcd-io#1378]Subchannel deleted]
logger.go:146: 2025-02-27T07:57:18.656Z INFO grpc [[transport] [client-transport 0xc0025f2248] Closing: rpc error: code = Canceled desc = grpc: the client connection is closing]
logger.go:146: 2025-02-27T07:57:18.656Z INFO grpc [[transport] [client-transport 0xc0025f2248] loopyWriter exiting with error: rpc error: code = Canceled desc = grpc: the client connection is closing]
logger.go:146: 2025-02-27T07:57:18.656Z INFO grpc [[transport] [server-transport 0xc000b56ea0] Closing: EOF]
=========================== compaction ==============
logger.go:146: 2025-02-27T07:57:18.656Z INFO m0 finished scheduled compaction {"member": "m0", "compact-revision": 2488, "took": "129.590742ms", "hash": 2489925777, "current-db-size-bytes": 40960, "current-db-size": "41 kB", "current-db-size-in-use-bytes": 40960, "current-db-size-in-use": "41 kB"}
=====================================================
```
Fixes: etcd-io#19497
Signed-off-by: Wei Fu <[email protected]>
|
Hi @k8s-infra-cherrypick-robot. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
|
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## release-3.6 #19541 +/- ##
===============================================
- Coverage 68.95% 68.92% -0.03%
===============================================
Files 420 420
Lines 35788 35788
===============================================
- Hits 24677 24668 -9
- Misses 9686 9693 +7
- Partials 1425 1427 +2 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Member
|
/retest |
ahrtr
approved these changes
Mar 5, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #19538
/assign ahrtr